[PATCH] D109259: [SROA] Support opaque pointers

[Nikita Popov via Phabricator via llvm-commits]

nikic marked an inline comment as done.
nikic added inline comments.


================
Comment at: llvm/test/Transforms/SROA/basictest-opaque-ptrs.ll:122
+; CHECK-NEXT:    [[TMP0:%.*]] = getelementptr inbounds i8, ptr [[A_SROA_0]], i64 2
+; CHECK-NEXT:    store i64 [[X:%.*]], ptr [[TMP0]], align 1
+; CHECK-NEXT:    br label [[L2:%.*]]
----------------
aeubanks wrote:
> in the original test this is a `i64 addrspace(1)*` but here we've dropped the `addrspace(1)`
> are we missing an addrspacecast? the original code path had a cast if the final pointer type didn't match the desired pointer type
Nice catch! I've added the missing pointer cast.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109259/new/

https://reviews.llvm.org/D109259