[PATCH] D106618: [Clang][LLVM] generate btf_tag annotations for DISubprogram types

[Yonghong Song via Phabricator via llvm-commits]

yonghong-song added inline comments.


================
Comment at: clang/test/CodeGen/attr-btf_tag-disubprogram-2.c:5-14
+#define __tag2 __attribute__((btf_tag("tag2")))
+
+struct t1 {
+  int a;
+};
+
+extern int __tag1 __tag2 foo(struct t1 *);
----------------
dblaikie wrote:
> Any particular reason this needs to be split out into its own file (perhaps the filename could describe the reason a bit - help explain what's tricky/different about this, rather than being differentiated only by `1` or `2`), or could this be rolled into the other test file?
The reason is -1 doesn't have any optimization flag and -2 has -O2 in order to generate debuginfo. I will rename the second file with suffix like -callsite to be clear.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106618/new/

https://reviews.llvm.org/D106618