[PATCH] D108260: [AArch64][GlobalISel] Mark G_FMINNUM/G_FMAXNUM as floating point opcodes

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64RegisterBankInfo.cpp:428
+  case TargetOpcode::G_FMAXNUM:
+  case TargetOpcode::G_FMINNUM:
     return true;
----------------
jroelofs wrote:
> how about these?
> 
> ```
> G_FMINNUM_IEEE
> G_FMAXNUM_IEEE
> G_FMAXIMUM
> G_FMINIMUM
> G_FCOPYSIGN
> G_FCANONICALIZE
> G_FMAD
> G_FREM
> G_FEXP2
> ```
> 
We should add them, but we can't test it until they're actually legalized.

Regbankselect needs the `legalized` property on the MachineFunction, so if we have any instructions which aren't legal, we'll get an error. :(


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108260/new/

https://reviews.llvm.org/D108260