[PATCH] D107459: [X86] Rename Subtarget Tuning Feature Flag Prefix. NFC.

Pengfei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 4 08:48:12 PDT 2021


pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks Simon. Quick implementation!



================
Comment at: llvm/lib/Target/X86/X86TargetTransformInfo.h:68
+      X86::TuningPOPCNTFalseDeps,
       X86::FeatureSSEUnalignedMem,
+      X86::TuningSlow3OpsLEA,
----------------
Nit, it looks a bit strange in the middle of all TuningXXX. Maybe better to hoist to the top or give a separate comment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107459/new/

https://reviews.llvm.org/D107459



More information about the llvm-commits mailing list