[PATCH] D107133: [AVR] emit `MCSA_Global` references to `__do_global_ctors` and `__do_global_dtors`

Matt Jacobson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 4 00:23:57 PDT 2021


mhjacobson added inline comments.


================
Comment at: llvm/lib/Target/AVR/AVRAsmPrinter.cpp:226
+
+  OutStreamer->emitRawComment(" Declaring this symbol tells the CRT that it should");
+  OutStreamer->emitRawComment("copy all variables from program memory to RAM on startup");
----------------
MaskRay wrote:
> Leading space is not needed
The leading space seems to be pretty common for calls to `emitRawComment`, not just in the AVR target but others too.  It turns

```
;Declaring this symbol
```

into

```
; Declaring this symbol
```

which looks prettier for anyone having to look at the generated assembly.

(I'll fix the linter complaint.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107133/new/

https://reviews.llvm.org/D107133



More information about the llvm-commits mailing list