[PATCH] D107384: Simplify coro::salvageDebugInfo() (NFC-ish)

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu added inline comments.


================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:2533-2537
+      Value *Op = llvm::salvageDebugInfoImpl(
+          *Inst, Expr ? Expr->getNumLocationOperands() : 0, Ops,
           AdditionalValues);
-      if (!Storage)
+      if (!Op)
         break;
----------------
If `Op` is null and we break this loop, Storage would still be no-nullptr. It means that it wouldn't trigger the condition in 2547, then there could be a potential bug to me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107384/new/

https://reviews.llvm.org/D107384