[PATCH] D107060: [SPEC2017] Add timeit dependencies to validator and bench binaries.

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 29 12:51:50 PDT 2021


Meinersbur added a comment.

Shouldn't the top-level CMakeLists.txt be responsible to build `build-timeit` before building anything? This looks like a recursive problem because `TEST_SUITE_COLLECT_COMPILE_TIME` sets

  set(CMAKE_C_COMPILE_OBJECT "${CMAKE_BINARY_DIR}/tools/timeit --summary <OBJECT>.time ${CMAKE_C_COMPILE_OBJECT}")

but that command line is also used to compile `timeit.c`. How does this even work?


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107060/new/

https://reviews.llvm.org/D107060



More information about the llvm-commits mailing list