[PATCH] D106716: [Bazel] Swap stray td_srcs to deps

[Geoffrey Martin-Noble via Phabricator via llvm-commits]

GMNGeoffrey created this revision.
Herald added subscribers: dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini.
GMNGeoffrey requested review of this revision.
Herald added subscribers: llvm-commits, stephenneuendorffer, nicolasvasilache.
Herald added a project: LLVM.

This is the last instance of td_srcs in MLIR core build files. `deps` is
generally preferred. There are still some cases where `td_srcs` is
useful where creating a td_library would just be another layer of
indirection, so not (yet) dropping it entirely.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D106716

Files:
  utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel


Index: utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel
===================================================================
--- utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel
+++ utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel
@@ -160,10 +160,10 @@
     ],
     tblgen = "//mlir:mlir-tblgen",
     td_file = "lib/Dialect/Test/TestAttrDefs.td",
-    td_srcs = [
+    test = True,
+    deps = [
         ":TestOpTdFiles",
     ],
-    test = True,
 )
 
 gentbl_cc_library(


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106716.361358.patch
Type: text/x-patch
Size: 492 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210723/0c8fb542/attachment.bin>