[PATCH] D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type

Mon Jul 19 17:10:47 PDT 2021

MaskRay reopened this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Reverted due to an use-of-uninitialized-value bug.

================
Comment at: lld/test/wasm/duplicate-table-imports.s:43
+
+# XXX: the second imported table has index 1, not 0. I've verified by hand (with
+# `wasm2wat`) that the resulting Wasm file is correct: `t3` does end up at index
----------------
Newer tests in other lld ports use `##` for non-CHECK-non-RUN comments.

================
Comment at: lld/wasm/SyntheticSections.h:99

+/**
+ * A key for some kind of imported entity of type `T`.
----------------
The coding standard doesn't use `/*`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105519/new/

https://reviews.llvm.org/D105519