[PATCH] D106143: [CMake][TSAN] Add build dependency against libcxx

[Adrian Vogelsgesang via Phabricator via llvm-commits]

avogelsgesang added a comment.

Some more context:

Without this patch, our build system failed with the output:

  [12:12:49] :					 [clang-build-stage1] [ 68%] Building CXX object compiler-rt/lib/tsan/CMakeFiles/clang_rt.tsan_iossim_dynamic.dir/rtl/tsan_external.cpp.o
  [12:12:49] :					 [clang-build-stage1] [ 68%] Copying CXX header __support/xlocale/__strtonum_fallback.h
  [12:12:49] :					 [clang-build-stage1] [ 68%] Building CXX object compiler-rt/lib/tsan/CMakeFiles/RTTsan_dynamic.iossim.dir/rtl/tsan_rtl_thread.cpp.o
  [12:12:49] :					 [clang-build-stage1] [ 68%] Copying CXX header system_error
  [12:12:49] :					 [clang-build-stage1] [ 68%] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan_dynamic.osx.dir/asan_new_delete.cpp.o
  [12:12:49] :					 [clang-build-stage1] [ 68%] Copying CXX header tgmath.h
  [12:12:49] :					 [clang-build-stage1] [ 68%] Copying CXX header thread
  [12:12:49] :					 [clang-build-stage1] [ 68%] Building CXX object compiler-rt/lib/tsan/CMakeFiles/RTTsan_dynamic.osx.dir/rtl/tsan_rtl.cpp.o
  [12:12:49] :					 [clang-build-stage1] [ 68%] Building CXX object compiler-rt/lib/tsan/CMakeFiles/RTTsan_dynamic.osx.dir/rtl/tsan_rtl_mutex.cpp.o
  [12:12:49] :					 [clang-build-stage1] [ 69%] Copying CXX header tuple
  [12:12:49] :					 [clang-build-stage1] In file included from /Volumes/build/tc/473843e25ae443f4/release/src/clang-osx10.11-x86_64-release-master_avogelsgesang-llvm12.12.0.1.c2458596.r74f7019d/compiler-rt/lib/asan/asan_new_delete.cpp:22:
  [12:12:49] :					 [clang-build-stage1] /Volumes/build/tc/473843e25ae443f4/release/src/clang-osx10.11-x86_64-release-master_avogelsgesang-llvm12.12.0.1.c2458596.r74f7019d/build/stage1_build/./bin/../include/c++/v1/stddef.h:39:10: fatal error: '__config' file not found
  [12:12:49] :					 [clang-build-stage1] #include <__config>
  [12:12:49] :					 [clang-build-stage1]          ^~~~~~~~~~
  [12:12:49] :					 [clang-build-stage1] 1 error generated.
  [12:12:49] :					 [clang-build-stage1] make[5]: *** [compiler-rt/lib/asan/CMakeFiles/RTAsan_dynamic.osx.dir/asan_new_delete.cpp.o] Error 1
  [12:12:49] :					 [clang-build-stage1] make[4]: *** [compiler-rt/lib/asan/CMakeFiles/RTAsan_dynamic.osx.dir/all] Error 2
  [12:12:49] :					 [clang-build-stage1] [ 69%] Copying CXX header type_traits
  [12:12:49] :					 [clang-build-stage1] [ 69%] Building CXX object compiler-rt/lib/tsan/CMakeFiles/clang_rt.tsan_osx_dynamic.dir/rtl/tsan_fd.cpp.o
  [12:12:49] :					 [clang-build-stage1] [ 69%] Copying CXX header typeindex
  [12:12:49] :					 [clang-build-stage1] [ 69%] Copying CXX header typeinfo
  [12:12:50] :					 [clang-build-stage1] [ 69%] Building CXX object compiler-rt/lib/tsan/CMakeFiles/clang_rt.tsan_iossim_dynamic.dir/rtl/tsan_fd.cpp.o
  [12:12:50] :					 [clang-build-stage1] [ 69%] Copying CXX header unordered_map
  [12:12:50] :					 [clang-build-stage1] [ 69%] Copying CXX header unordered_set
  [12:12:50] :					 [clang-build-stage1] [ 69%] Building CXX object compiler-rt/lib/tsan/CMakeFiles/clang_rt.tsan_iossim_dynamic.dir/rtl/tsan_flags.cpp.o
  [12:12:50] :					 [clang-build-stage1] [ 69%] Copying CXX header utility
  [12:12:50] :					 [clang-build-stage1] [ 69%] Copying CXX header valarray
  [12:12:50] :					 [clang-build-stage1] [ 69%] Building CXX object compiler-rt/lib/tsan/CMakeFiles/RTTsan_dynamic.osx.dir/rtl/tsan_rtl_proc.cpp.o
  [12:12:50] :					 [clang-build-stage1] [ 69%] Copying CXX header variant
  [12:12:50] :					 [clang-build-stage1] [ 69%] Copying CXX header vector
  [12:12:50] :					 [clang-build-stage1] [ 69%] Building CXX object compiler-rt/lib/tsan/CMakeFiles/clang_rt.tsan_iossim_dynamic.dir/rtl/tsan_ignoreset.cpp.o
  [12:12:50] :					 [clang-build-stage1] [ 69%] Copying CXX header version
  [12:12:50] :					 [clang-build-stage1] [ 69%] Building CXX object compiler-rt/lib/tsan/CMakeFiles/RTTsan_dynamic.osx.dir/rtl/tsan_rtl_report.cpp.o
  [12:12:50] :					 [clang-build-stage1] [ 69%] Building CXX object compiler-rt/lib/tsan/CMakeFiles/clang_rt.tsan_osx_dynamic.dir/rtl/tsan_flags.cpp.o
  [12:12:50] :					 [clang-build-stage1] [ 69%] Copying CXX header wchar.h
  [12:12:50] :					 [clang-build-stage1] [ 70%] Copying CXX header wctype.h
  [12:12:50] :					 [clang-build-stage1] [ 70%] Building CXX object compiler-rt/lib/tsan/CMakeFiles/clang_rt.tsan_iossim_dynamic.dir/rtl/tsan_interceptors_posix.cpp.o
  [12:12:50] :					 [clang-build-stage1] [ 71%] Building CXX object compiler-rt/lib/tsan/CMakeFiles/RTTsan_dynamic.iossim.dir/rtl/tsan_stack_trace.cpp.o
  [12:12:50] :					 [clang-build-stage1] [ 71%] Copying CXX __config
  [12:12:50] :					 [clang-build-stage1] [ 71%] Built target generate-cxx-headers

Note how the missing include `__config` occurred at 12:12:49, and "Copying CXX __config" took place 1 second later, at 12:12:50


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106143/new/

https://reviews.llvm.org/D106143