[PATCH] D104308: [VP] Add vector-predicated reduction intrinsics

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 15 04:36:16 PDT 2021


frasercrmck updated this revision to Diff 358920.
frasercrmck marked 7 inline comments as done.
frasercrmck added a comment.

fix Verifier test
fix VPReductionIntrinsic::classof
add new unit test
update docs:

- fix references to operand indices
- fix neutral element for AND reduction
- fix specified return value for FMIN/FMAX and NaNs
- be more explicit about return value EVL==0
- be more explicit about start value
- reference operands by their names in `Arguments` sections


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104308/new/

https://reviews.llvm.org/D104308

Files:
  llvm/docs/LangRef.rst
  llvm/include/llvm/IR/IntrinsicInst.h
  llvm/include/llvm/IR/Intrinsics.td
  llvm/include/llvm/IR/VPIntrinsics.def
  llvm/lib/CodeGen/ExpandVectorPredication.cpp
  llvm/lib/IR/IntrinsicInst.cpp
  llvm/test/CodeGen/Generic/expand-vp.ll
  llvm/test/Verifier/vp-intrinsics.ll
  llvm/unittests/IR/VPIntrinsicTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104308.358920.patch
Type: text/x-patch
Size: 78908 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210715/e761fea5/attachment.bin>


More information about the llvm-commits mailing list