[PATCH] D105338: [InstCombine] Revert "Temporarily do not drop volatile stores before unreachable"

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 9 08:20:28 PDT 2021


thakis added a comment.

In D105338#2867153 <https://reviews.llvm.org/D105338#2867153>, @nikic wrote:

> @thakis I think everyone here would be happy with this being reverted //**as soon as someone submits a LangRef patch and RFC to llvm-dev for changing the specified behavior of volatile stores in LLVM**//. I'd personally also be fine with this being reverted as long as someone takes //**personal responsibility**// for providing such a LangRef patch and RFC //**as soon as possible**//.

I think this mixes up several things. This breaks users of LLVM who care about that their stuff works and who've never looked at the LangRef. They shouldn't have to pay for that we don't have our house in order.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105338/new/

https://reviews.llvm.org/D105338



More information about the llvm-commits mailing list