[PATCH] D72223: [MLIR] Introduce affine.execute_region op

Uday Bondhugula via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 27 20:22:49 PDT 2021


bondhugula added inline comments.


================
Comment at: mlir/lib/Dialect/Affine/IR/AffineOps.cpp:2673
+  Region *region = result.addRegion();
+  Block *body = new Block();
+  region->push_back(body);
----------------
ftynse wrote:
> We can now do `builder.createBlock`
Unfortunately, using this messes up the insertion point subsequently - outweighs the idiomacy it provides and I'd like to avoid using a scope guard.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72223/new/

https://reviews.llvm.org/D72223



More information about the llvm-commits mailing list