[PATCH] D104827: [DebugInfo] Enforce implicit constraints on `distinct` MDNodes

[Scott Linder via Phabricator via llvm-commits]

scott.linder added reviewers: StephenTozer, dblaikie, probinson, vsk, aprantl, jmorse, t-tye, kzhuravl, RamNalamothu.
scott.linder added a comment.

This is my attempt to address a bug with `distinct` `DIExpression`s being accepted by the parser, but not round-tripping.

In general it seemed like it would be nice to have high level properties of the MDNode types all in Metadata.def, and it also seemed nice to make the "inlined" property depend on the fact that a node is always uniqued, as printing a distinct node inline seems impossible (or at least misleading) unless we invent some new syntax for it.

I got all the way to the MIR parser changes and then wasn't sure why e.g. DILocation is handled specially. I stopped before pushing the changes through there in order to get feedback on the general approach first; any comments are welcomed!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104827/new/

https://reviews.llvm.org/D104827