[PATCH] D104191: [LVI] Remove recursion from getValueForCondition (NFC)

Carl Ritson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 12 23:37:30 PDT 2021


critson created this revision.
critson added reviewers: nikic, guopeilin, fhahn, lebedev.ri.
Herald added subscribers: pengfei, hiraditya.
critson requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Convert getValueForCondition to a worklist model instead of using
recursion.

In pathological cases getValueForCondition recurses heavily.
Stack frames are quite expensive on x86-64, and some operating
systems (e.g. Windows) have relatively low stack size limits.
Using a worklist avoids potential failures from stack overflow.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D104191

Files:
  llvm/lib/Analysis/LazyValueInfo.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104191.351699.patch
Type: text/x-patch
Size: 4711 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210613/2422cb58/attachment.bin>


More information about the llvm-commits mailing list