[PATCH] D103560: [flang] Check for duplicate definitions of defined input/output procedures

[Pete Steinfeld via Phabricator via llvm-commits]

PeteSteinfeld added inline comments.


================
Comment at: flang/lib/Semantics/check-declarations.cpp:1769
+  seenDefinedIoTypes_.emplace_back(
+      TypeWithDefinedIo{derivedType, ioKind, proc});
+}
----------------
klausler wrote:
> I think you don't need or even want the `TypeWithDefinedIo` constructor here; just list the arguments.  Otherwise it's a copy of a constructed value, not construction in place.
Thanks, Peter.

I can't figure out how to get rid of the name of the type and get things to compile.  I get an error message from G++ that says "no matching function ..."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103560/new/

https://reviews.llvm.org/D103560