[PATCH] D53927: [AArch64] Enable libm vectorized functions via SLEEF

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 21 03:56:16 PDT 2021


rengolin added a comment.

Hi @georgemitenkov,

This was a long time ago, I completely forgot about this.

I was happy with the patch before and I have no reason to hot be happy now, but we need someone else to have a look to make sure we don't revert it back again.

@echristo @arsenm @hfinkel would be good candidates.

That is, of course, if @steleman and @joelkevinjones are still interested in pushing this forward (and its clang counterpart, which now can be atomically committed together due to the monorepo).

The main pending issue I see, reading back the comments, is a split on the intrinsics. I personally don't think it's a good idea, but am not opposed to such a change. It'd be up to the authors and other reviewers to decide on that, though.

As it stands, despite having been approved by me and @fpetrogalli, it would need an additional approval by another reviewer (preferably one of the three mentioned above) to be committed.

Thanks,
--renato


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53927/new/

https://reviews.llvm.org/D53927



More information about the llvm-commits mailing list