[PATCH] D102612: SwiftTailCC: teach verifier musttail rules applicable to this CC.

Tim Northover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 17 04:39:35 PDT 2021


t.p.northover created this revision.
t.p.northover added reviewers: jroelofs, paquette.
Herald added subscribers: dexonsmith, jdoerfert, pengfei, hiraditya, mcrosier.
t.p.northover requested review of this revision.
Herald added a project: LLVM.

SwiftTailCC has a different set of requirements than the C calling convention for a tail call. The exact argument sequence doesn't have to match, but fewer ABI-affecting attributes are allowed (mostly to be conservative and because we have a reasonable idea of what might actually be useful).

Also make sure the musttail diagnostic triggers if a musttail call isn't actually a tail call.


https://reviews.llvm.org/D102612

Files:
  llvm/docs/LangRef.rst
  llvm/lib/IR/Verifier.cpp
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/lib/Target/ARM/ARMISelLowering.cpp
  llvm/lib/Target/X86/X86ISelLowering.cpp
  llvm/test/CodeGen/AArch64/swifttail-call.ll
  llvm/test/CodeGen/X86/tailcall-swifttailcc.ll
  llvm/test/Verifier/swifttailcc-musttail-valid.ll
  llvm/test/Verifier/swifttailcc-musttail.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102612.345831.patch
Type: text/x-patch
Size: 17817 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210517/1221e159/attachment.bin>


More information about the llvm-commits mailing list