[PATCH] D102588: [UpdateTestChecks] Default --x86_scrub_rip to False

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 16 18:25:48 PDT 2021


MaskRay added a comment.

In D102588#2762305 <https://reviews.llvm.org/D102588#2762305>, @hvdijk wrote:

> The switch to `--no-x86_scrub_rip` by default makes sense to me.
>
> You've not enabled `--x86_scrub_rip` for any test as far as I see, right? Do we know what tests the option is useful for? If so, perhaps their update_llc_test_checks invocations could be updated already.

It's the default. The updated tests have revealed the differences.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102588/new/

https://reviews.llvm.org/D102588



More information about the llvm-commits mailing list