[PATCH] D102318: [TargetRegisterInfo] Speed up getAllocatableSet. NFCI.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 12 01:40:02 PDT 2021


foad created this revision.
foad added reviewers: arsenm, qcolombet, bsaleil.
Herald added subscribers: hiraditya, tpr.
foad requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

MachineRegisterInfo caches the reserved register set that is computed by
by TargetRegisterInfo::getReservedRegs, so call into MRI to get the
reserved regs to avoid recomputing them.

In particular this speeds up AMDGPU's SIFormMemoryClauses pass because
AMDGPU has a particularly complicated reserved set that is expensive to
compute.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D102318

Files:
  llvm/lib/CodeGen/TargetRegisterInfo.cpp


Index: llvm/lib/CodeGen/TargetRegisterInfo.cpp
===================================================================
--- llvm/lib/CodeGen/TargetRegisterInfo.cpp
+++ llvm/lib/CodeGen/TargetRegisterInfo.cpp
@@ -267,8 +267,9 @@
   }
 
   // Mask out the reserved registers
-  BitVector Reserved = getReservedRegs(MF);
-  Allocatable &= Reserved.flip();
+  const MachineRegisterInfo &MRI = MF.getRegInfo();
+  const BitVector &Reserved = MRI.getReservedRegs();
+  Allocatable.reset(Reserved);
 
   return Allocatable;
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102318.344715.patch
Type: text/x-patch
Size: 515 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210512/401ab5d9/attachment.bin>


More information about the llvm-commits mailing list