[PATCH] D96883: Add support for JSON output style to llvm-symbolizer

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/test/tools/llvm-symbolizer/output-style-json-frame.test:38
+##
+## clang --target=aarch64-linux-android -fsanitize=hwaddress -fsanitize-hwaddress-abi=platform frame.c -O -g -S -o frame.s
+
----------------
This seems like a fairly non-trivial build - might be worth an explanation about what's interesting about this case that's not exercised by simpler cases (such as ones without sanitizers, maybe also x86 plain (not a necessity, but curious if it's something ARM specific here), etc)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96883/new/

https://reviews.llvm.org/D96883