[compiler-rt] bf61690 - asan: fix a windows test

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 30 13:52:10 PDT 2021


Author: Dmitry Vyukov
Date: 2021-04-30T13:51:58-07:00
New Revision: bf61690e92b210c8934918152bed2932cf665105

URL: https://github.com/llvm/llvm-project/commit/bf61690e92b210c8934918152bed2932cf665105
DIFF: https://github.com/llvm/llvm-project/commit/bf61690e92b210c8934918152bed2932cf665105.diff

LOG: asan: fix a windows test

Before commit "sanitizer_common: introduce kInvalidTid/kMainTid"
asan invalid/unknown thread id was 0xffffff, so presumably we printed "T16777215".
Now it's -1, so we print T-1. Fix the test.
I think the new format is even better, "T-1" clearly looks like something special
rather than a random large number.

Reviewed By: vitalybuka

Differential Revision: https://reviews.llvm.org/D101634

Added: 
    

Modified: 
    compiler-rt/test/asan/TestCases/Windows/queue_user_work_item_report.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/asan/TestCases/Windows/queue_user_work_item_report.cpp b/compiler-rt/test/asan/TestCases/Windows/queue_user_work_item_report.cpp
index cc57b3b7e5ff5..aa618cbe8d8ce 100644
--- a/compiler-rt/test/asan/TestCases/Windows/queue_user_work_item_report.cpp
+++ b/compiler-rt/test/asan/TestCases/Windows/queue_user_work_item_report.cpp
@@ -10,7 +10,7 @@ DWORD CALLBACK work_item(LPVOID) {
   volatile char stack_buffer[42];
   stack_buffer[subscript] = 42;
   // CHECK: AddressSanitizer: stack-buffer-underflow on address [[ADDR:0x[0-9a-f]+]]
-  // CHECK: WRITE of size 1 at [[ADDR]] thread T{{[0-9]+}}
+  // CHECK: WRITE of size 1 at [[ADDR]] thread T-1
   // CHECK:   {{#0 .* work_item.*queue_user_work_item_report.cpp}}:[[@LINE-3]]
   SetEvent(done);
   return 0;
@@ -20,7 +20,7 @@ int main(int argc, char **argv) {
   done = CreateEvent(0, false, false, "job is done");
   if (!done)
     return 1;
-// CHECK-NOT: Thread T1 created
+  // CHECK-NOT: Thread {{.*}} created
   QueueUserWorkItem(&work_item, nullptr, 0);
   if (WAIT_OBJECT_0 != WaitForSingleObject(done, 10 * 1000))
     return 2;


        


More information about the llvm-commits mailing list