[PATCH] D101318: [TableGen] Add the !find bang operator

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 27 10:54:07 PDT 2021


dblaikie added a comment.

In D101318#2720374 <https://reviews.llvm.org/D101318#2720374>, @Paul-C-Anagnostopoulos wrote:

> I will push this on Wednesday.
>
> @dblaikie: What is your opinion on adding an assertion to a TableGen file when the backend(s) are already checking the condition? I think putting the checking closer to the problem is a good thing, and may result in more specific error messages. But, on the other hand, one could argue that it's pointless work.

Seems plausibly useful - though no doubt send such changes for review by the specific tblgen authors to see what they think (I've never written/modified target tblgens - so I'm on the fringes of this work at best).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101318/new/

https://reviews.llvm.org/D101318



More information about the llvm-commits mailing list