[PATCH] D101238: X86/GlobalISel: Use generic version of splitToValueTypes

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 24 09:42:38 PDT 2021


arsenm created this revision.
arsenm added reviewers: aemerson, paquette, bogner, dsanders, craig.topper, igorb.
Herald added subscribers: pengfei, hiraditya, rovka.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

The custom insert of an unmerge and the callback weirdness should be
unnecessary. Since handleAssignments should now use
getRegisterTypeForCalling conv as SelectionDAG builder would, this
should now just be able to use the generic code. X86-32 relies on the
generated CCAssignFns not seeing illegal types and sharing code with
x86_64, so i64 values would incorrectly be assigned to 64-bit
registers.


https://reviews.llvm.org/D101238

Files:
  llvm/lib/Target/X86/X86CallLowering.cpp
  llvm/lib/Target/X86/X86CallLowering.h
  llvm/test/CodeGen/X86/GlobalISel/irtranslator-callingconv.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101238.340294.patch
Type: text/x-patch
Size: 12289 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210424/509937e4/attachment.bin>


More information about the llvm-commits mailing list