[PATCH] D83578: [test] Replace a fragile lit feature (substitution in an argument place) with command -v

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

> lit can do substitution in an argument place (like llvm-ar in ln -s llvm-ar) which is counterintuitive.

Why is it counterintuitive? To me, it is most intuitive if references to an LLVM executable are always to the version in the build directory. By substituting the full path, it is always possible to see which version of a tool is actually being referenced, which is important for test debugging, if nothing else.

FWIW, I find the patch makes the testd less readable. Admittedly, I'm not a massive Linux user, but I had to look up the meaning of `command -v` online, and it's quite likely I'll forget it again later. It's also not clear to future test writers why one might need to use this pattern.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83578/new/

https://reviews.llvm.org/D83578