[PATCH] D69428: [GlobalOpt] Remove valgrind specific hacks (revert r160529)

Eugene Leviant via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 14 03:23:09 PDT 2021


evgeny777 added a comment.

> Just how much do we gain by eliminating these locations? Are we talking 10%, 1%, or what?

I don't know, but preventing optimization to appease valgrind looks .. hm.. strange. I agree with @nlopes that `__attribute__((__used__))` should be used for such purpose (probably added from some instrumentation pass)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69428/new/

https://reviews.llvm.org/D69428



More information about the llvm-commits mailing list