[PATCH] D99469: GlobalISel: Restrict narrow scalar for fptoui/fptosi results

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 10 06:58:19 PDT 2021


arsenm added a comment.

In D99469#2657766 <https://reviews.llvm.org/D99469#2657766>, @foad wrote:

> The code change looks fine to me. The added tests aren't actually testing any behaviour that has changed, are they? Is there any reasonable way to add tests for the unable-to-legalize case?

That is what's tested here. The no-ops in the new tests demonstrate they weren't legalized.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99469/new/

https://reviews.llvm.org/D99469



More information about the llvm-commits mailing list