[PATCH] D99423: [DebugInfo] Fix incorrect updating of SDNode dependencies for variadic debug values

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 9 09:21:52 PDT 2021


StephenTozer updated this revision to Diff 336490.
StephenTozer added a comment.

Small update: explicitly deleted the copy constructors and destructor for `SDDbgValue` with an explanatory comment, to ensure that if we ever start copy constructing or destroying instances of `SDDbgValue` there will be notice that the raw pointers need to be managed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99423/new/

https://reviews.llvm.org/D99423

Files:
  llvm/lib/CodeGen/SelectionDAG/SDNodeDbgValue.h
  llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/test/CodeGen/X86/dbg-list-dependencies.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99423.336490.patch
Type: text/x-patch
Size: 23648 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210409/9b939128/attachment.bin>


More information about the llvm-commits mailing list