[PATCH] D100063: [AMDGPU] Split GCNRegBankReassign

Wed Apr 7 13:45:25 PDT 2021

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

In D100063#2675053 <https://reviews.llvm.org/D100063#2675053>, @rampitec wrote:

> If you will run rewriter once no changes are needed at all. Just run the pass right before the rewriter. Although currently you are running it twice. What are your plans about this?

I would need to look at it again. For now I guess assume the rewrite will run twice

================
Comment at: llvm/lib/Target/AMDGPU/GCNRegBankReassign.cpp:400

   if (MI.isDebugValue())
     return std::make_pair(StallCycles, UsedBanks);
----------------
Unrelated, but this is likely a bug. This should cover all meta instructions (most likely this will do the wrong thing for kill)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100063/new/

https://reviews.llvm.org/D100063