[PATCH] D100003: [lld-macho] Sibling N_SO symbols must have the empty string

[Jez Ng via Phabricator via llvm-commits]

int3 created this revision.
int3 added reviewers: lld-macho, clayborg.
Herald added a reviewer: JDevlieghere.
Herald added a project: lld-macho.
int3 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

We had been giving them a string index of zero, which actually corresponds to a
string with a single space due to D89639: [lld-macho] Emit empty string as first entry of string table <https://reviews.llvm.org/D89639>.

This was far from obvious in the old test because llvm-nm doesn't quote the
symbol names, making the empty string look identical to a string of a single
space. `dsymutil -s` quotes its strings, so I've changed the test accordingly.

Fixes llvm.org/PR48714. Thanks @clayborg for the tips!


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D100003

Files:
  lld/MachO/SyntheticSections.h
  lld/test/MachO/stabs.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100003.335696.patch
Type: text/x-patch
Size: 9000 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210407/0d76023d/attachment-0001.bin>