[PATCH] D99620: [CMake][Compiler-rt] Compute LLVM_MAIN_SRC_DIR assuming the monorepo layout.

[Dan Liew via Phabricator via llvm-commits]

delcypher added a comment.

@phosek Thanks for the review.



================
Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:277
+  # CMake cache value.
+  get_compiler_rt_root_source_dir(CRT_SRC_ROOT_PATH)
+  get_filename_component(LLVM_MAIN_SRC_DIR_DEFAULT "${CRT_SRC_ROOT_PATH}/../llvm" ABSOLUTE)
----------------
phosek wrote:
> I'd avoid `CRT` because that can be confused with CRT subproject of compiler-rt: https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/CMakeLists.txt#L20
Thanks. I've renamed the variable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99620/new/

https://reviews.llvm.org/D99620