[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

Mon Apr 5 19:14:42 PDT 2021

TaoPan added a comment.

Hi tmsriram, MaskRay,

I updated implementation and test. Could you please have a look?
As for multiple COMDAT seletion kinds of PE-COFF, is IMAGE_COMDAT_SELECT_NODUPLICATES wrong? Or need to set different COMDAT selection kind in some case?
As for a holistic plan how every component is going to be implemented, I'm developing

1. Basic block sections Windows exception handling, I'm not sure whether need to handle exception handling sections like ELF sections ".eh.*" here, anyway, I'll make sure Windows exception handling work on basic block sections.
2. MFS on Windows, I submitted D95209 <https://reviews.llvm.org/D95209>, it includes text section with prefix ".text$split" handling, it will be updated after landing this patch.

in turn.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99487/new/

https://reviews.llvm.org/D99487