[PATCH] D99399: [elfabi] Prepare llvm-elfabi for elfabi/ifs merging.

Puyan Lotfi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 25 22:37:14 PDT 2021


plotfi added a comment.

I will take another look over this commit in the morning. Overall looks good.



================
Comment at: llvm/lib/InterfaceStub/ELFStub.cpp:56
+Expected<ELFArch> llvm::elfabi::convertArchNameToEMachine(StringRef Arch) {
+  // TODO: Support all availabe architectures.
+  if (Arch == "x86_64")
----------------
Can we populate this in this commit?



================
Comment at: llvm/lib/InterfaceStub/ELFStub.cpp:66
+llvm::elfabi::convertEMachineToArchName(ELFArch EMachine) {
+  // TODO: Support all availabe architectures.
+  switch (EMachine) {
----------------
Can we populate this in this commit? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99399/new/

https://reviews.llvm.org/D99399



More information about the llvm-commits mailing list