[PATCH] D98929: Add missing cases in RISCVMCExpr::getVariantKindName

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 23 22:02:11 PDT 2021


craig.topper requested changes to this revision.
craig.topper added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVMCExpr.cpp:136
       .Case("tls_gd_pcrel_hi", VK_RISCV_TLS_GD_HI)
+      .Case("call", VK_RISCV_CALL)
+      .Case("call_plt", VK_RISCV_CALL_PLT)
----------------
Looking again. The only caller of this is RISCVAsmParser::parseOperandWithModifier. Are we allowing something additional in assembly parsing with this change? Is that something we should test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98929/new/

https://reviews.llvm.org/D98929



More information about the llvm-commits mailing list