[PATCH] D99234: [RISCV] Add predicates to zfh floating-point-to-floating-point conversion instructions and patterns

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 23 20:36:02 PDT 2021


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZfh.td:198
 
+let Predicates = [HasStdExtZfh, HasStdExtF] in {
+def FCVT_H_S : FPUnaryOp_r_frm<0b0100010, FPR16, FPR32, "fcvt.h.s">,
----------------
Since HasStdExtZfh requires HasStdExtF, I'm not sure this really does anything. We don't use [HasStdExtD, HasStdExtF] in RISCVInstrInfoD.td


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99234/new/

https://reviews.llvm.org/D99234



More information about the llvm-commits mailing list