[PATCH] D98145: [FastISel] Don't trivially kill extractvalues (PR49467)

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

I don't know this well, so a couple of drive-by comments inline.
@craig.topper or @RKSimon should have a look.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/FastISel.cpp:241
 
 bool FastISel::hasTrivialKill(const Value *V) {
   // Don't consider constants or arguments to have trivial kills.
----------------
The header comment for this function only says:
  /// Test whether the given value has exactly one use.

That should be updated with a little more detail about the logic and usage.


================
Comment at: llvm/test/CodeGen/X86/pr49467.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -O0 -verify-machineinstrs -mtriple=x86_64 < %s | FileCheck %s
+
----------------
Does it make sense to specify the point-of-failure in the RUN line more explicitly with something like:
  -fast-isel -optimize-regalloc=0


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98145/new/

https://reviews.llvm.org/D98145