[PATCH] D97427: [AMDGPU] Do not annotate an else branch if there is a kill

[Piotr Sobczak via Phabricator via llvm-commits]

piotr added a comment.

Alternatively, you could create the set of blocks containing a kill in advance - by looking at function declarations in the module, and if a kill is found then checking its users to find blocks. Whether that would be better depends on how often hasKill() is called, though.



================
Comment at: llvm/lib/Target/AMDGPU/SIAnnotateControlFlow.cpp:187
+bool SIAnnotateControlFlow::hasKill(const BasicBlock *BB) {
+  for (const Instruction &I : *BB) {
+    if (const CallInst *CI = dyn_cast<CallInst>(&I))
----------------
Bail out if calling convention is not CallingConv::AMDGPU_PS ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97427/new/

https://reviews.llvm.org/D97427