[PATCH] D96639: [AMDGPU] Add two TSFlags: IsAtomicNoRtn and IsAtomicRtn

Mon Feb 15 09:00:34 PST 2021

rampitec added inline comments.

================
Comment at: llvm/lib/Target/AMDGPU/SIDefines.h:111
+
+  IsAtomicNoRtn = UINT64_C(1) << 57,
+
----------------
foad wrote:
> This one lacks a comment.
> 
> Can you spell it "IsAtomicNoRet"? I don't think we use the "rtn"/"nortn" spelling anywhere else.
Actually we are using "rtn" in the td files. I was looking what do we use more, "ret" or "rtn" and got the impression "rtn" is used more often. I do not have a strong preference though.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96639/new/

https://reviews.llvm.org/D96639