[PATCH] D96387: [CSSPGO][llvm-profgen] Renovate perfscript check and command line input validation

[Lei Wang via Phabricator via llvm-commits]

wlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:22
 
+#ifndef STDOUT_FILENO
+#define STDOUT_FILENO 1
----------------
hoy wrote:
> Why need this? Will `std::out` work?
This is redundant, removed.


================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.h:261
   }
+  static bool showDisassembly();
+  static bool isShowDisassemblyOnlyEnabled();
----------------
hoy wrote:
> Remove this since we are keeping only show-disassembly-only?
Yeah, overlook this, thanks for the reminder.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96387/new/

https://reviews.llvm.org/D96387