[PATCH] D91426: [PowerPC] Fix issue where binary uses a .got but is missing a .TOC.

[Stefan Pintilie via Phabricator via llvm-commits]

stefanp added inline comments.


================
Comment at: lld/test/ELF/ppc64-ld-got-dtprel.s:28
+## lo(i at got@dtprel) = &.got[1] - (.got+0x8000) & 0xffff = -32760
+## hi(j at got@dtprel) = (&.got[2] - (.got+0x8000) >> 16) & 0xffff = -1
+## j at got@dtprel = &.got[2] - (.got+0x8000) = -32752
----------------
NeHuang wrote:
> is the computation proper here? To me, &.got[2] is different from &.got[1]
You are correct the comment there is wrong.
It should probably be:
```
## hi(j at got@dtprel) = (&.got[2] - .got >> 16) & 0xffff = -1
```
I will fix that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91426/new/

https://reviews.llvm.org/D91426