[PATCH] D95399: [flang][fir] Upstream FIR dialect changes.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 28 21:40:11 PST 2021


mehdi_amini added inline comments.


================
Comment at: flang/test/Fir/fir-ops.fir:4
 // RUN: tco -emit-fir %s | tco -emit-fir | FileCheck %s
-// UNSUPPORTED: !fir
+// XFAIL: *
 
----------------
schweitz wrote:
> mehdi_amini wrote:
> > You're disabling the test here, what's happening?
> It gets re-enabled here. https://reviews.llvm.org/D95402#change-2yxFjt5wBEUu
Please try to organize patches that are scoped and tested individually, otherwise it is impossible to review and understand how things are tested and play together.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95399/new/

https://reviews.llvm.org/D95399



More information about the llvm-commits mailing list