[PATCH] D95539: [LV] Add analysis remark for mixed precision conversions

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 27 10:19:53 PST 2021


jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9324
+  }
+}
+
----------------
Nits:
- make the function static.
- Visited doesn't need to be a map, use a SmallPtrSet and check like this: `if (!Visited.insert(I).second) continue;`

 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95539/new/

https://reviews.llvm.org/D95539



More information about the llvm-commits mailing list