[PATCH] D94834: [Coroutine] Do not CoroElide if there are musttail calls

Xun Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 25 18:00:55 PST 2021


lxfind added a comment.

> And I think there are two cases about this example:
> (1) The musttail call is dominated by  `@llvm.subfn.addr(%handle, 1)` calls. Then `%handle` is destroyed at the musttail call, so it makes no sense that the musttail call returns `%handle`.
> (2) The musttail call isn't dominated by  `@llvm.subfn.addr(%handle, 1)` calls. Then the musttail call may returns `%handle`. And it doesn't matter since `%handle` won't be elided in this case.

In case (1), why is it that '%handle' must be destroyed at the musttail call?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94834/new/

https://reviews.llvm.org/D94834



More information about the llvm-commits mailing list