[PATCH] D94746: [AMDGPU] Move kill lowering to WQM pass and add live mask tracking

Piotr Sobczak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 15 02:21:44 PST 2021


piotr added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp:1048
                               MachineBasicBlock::iterator Before,
-                              unsigned SavedOrig) {
+                              Register SavedOrig, char NonWWMState) {
   MachineInstr *MI;
----------------
piotr wrote:
> It looks the new param NonWWMState is unused?
I can see you are going to use it in D94747, but as it stands now it will cause a build warning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94746/new/

https://reviews.llvm.org/D94746



More information about the llvm-commits mailing list