[PATCH] D94435: [SampleFDO] Add the support to split the function profiles with context into separate sections.

[Wei Mi via Phabricator via llvm-commits]

wmi marked an inline comment as done.
wmi added inline comments.


================
Comment at: llvm/include/llvm/ProfileData/SampleProf.h:169
+  // Indicate the section contains only profile without context.
+  SecFlagNoContext = (1 << 1)
 };
----------------
hoy wrote:
> Nit: how about name this `SecFlagNoCalleeContext` or `SecFlagFlat` or something? Just want to be a bit more clear as CS profile also uses the term context.
Make sense. I chose SecFlagFlat.


================
Comment at: llvm/include/llvm/ProfileData/SampleProfWriter.h:159
+const std::array<SmallVector<SecHdrTableEntry, 8>, NumOfLayout>
+    ExtBinaryLayoutTable = {
+        // Note that SecFuncOffsetTable section is written after SecLBRProfile
----------------
hoy wrote:
> Nit: name it `ExtBinaryHdrLayoutTable`?
That is better.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94435/new/

https://reviews.llvm.org/D94435