[PATCH] D93953: NFC: Remove simple_ilist comment mentioning ilist/iplist allocating

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 12 16:49:48 PST 2021


dexonsmith added a comment.

In D93953#2486016 <https://reviews.llvm.org/D93953#2486016>, @lanza wrote:

> On a similar note, I noticed elsewhere after fixing this that you mentioned in a commit message that you intended to remove `iplist` and `ilist` and rename as `owning_ilist` (or something of that sorts). Is that still on the table?

TBH, a little while after I fixed the UB that was causing miscompiles for us, I was pulled into other things and never got back to this. I'm certainly not working on it right now, although I'm happy to review things in this area (and maybe I'll dive back in a some point if no one else does...).

> Either way, the docs should be updated all around to account for either path name as there are still references to the pre-2016 implementation (e.g. https://llvm.org/docs/ProgrammersManual.html#dss-iplist).

Nice catch! If you're interested in writing a patch to fix the docs, that'd be awesome (especially since you seem to have a list of places that need updating), but let me know if not and I'll try to clean it up myself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93953/new/

https://reviews.llvm.org/D93953



More information about the llvm-commits mailing list