[PATCH] D94014: [InstCombine] reduce icmp(ashr X, C1), C2 to sign-bit test

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 11 06:14:12 PST 2021


spatel updated this revision to Diff 315782.
spatel added a comment.

Ping.
Note: I added a bitwidth > 2 constraint to be safe and avoid degenerate narrow bit patterns, but I'm not sure how to write negative tests for that would actually survive to this point in instcombine (instsimplify appears to reduce those first).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94014/new/

https://reviews.llvm.org/D94014

Files:
  llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
  llvm/test/Transforms/InstCombine/icmp-shr.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94014.315782.patch
Type: text/x-patch
Size: 8658 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210111/81f95063/attachment.bin>


More information about the llvm-commits mailing list