[PATCH] D94245: [NFC] Disallow unused prefixes in CodeGen/AMDGPU

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 7 10:44:47 PST 2021


mtrofin marked an inline comment as done.
mtrofin added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/lit.local.cfg:9-10
+# the default substitution of FileCheck will replace it to its full path.
+config.substitutions.insert(0, (fc.regex,
+    'FileCheck --allow-unused-prefixes=false'))
+
----------------
arsenm wrote:
> Why not just switch the default in filecheck?
there are still ~300 remaining tests elsewhere, so I'm going large dir by large dir and 'stopping the bleeding' first; then I'll switch it in FileCheck and remove the lit.config changes (which are super easy to find)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94245/new/

https://reviews.llvm.org/D94245



More information about the llvm-commits mailing list