[PATCH] D93654: [TableGen] Change getAllDerivedDefinitions() to return const vector &

Chris Lattner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 21 14:27:07 PST 2020


lattner added a comment.

Yeah just let the return construct it.  On the caller side, just say:  auto x = Records.getAllDerivedDefinitions(..)

You don't need to say "const ArrayRef<x>" for the same reason you don't need to say "const int x = foo();"  it doesn't add much value and causes confusion.

-Chris


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93654/new/

https://reviews.llvm.org/D93654



More information about the llvm-commits mailing list