[PATCH] D93561: [X86] Avoid generating invalid R_X86_64_GOTPCRELX relocations

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 18 14:48:27 PST 2020


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/test/MC/X86/gotpcrelx.s:17
+# CHECK-NEXT:     R_X86_64_REX_GOTPCRELX sub
+# CHECK-NEXT:     R_X86_64_REX_GOTPCRELX xor
 # CHECK-NEXT:     R_X86_64_GOTPCRELX mov
----------------
Consider moving add R_X86_64_REX_GOTPCRELX instructions below R_X86_64_REX_GOTPCRELX ones.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93561/new/

https://reviews.llvm.org/D93561



More information about the llvm-commits mailing list